[BE][PIPELINE] Add fix for the wgmma pipelining bug with subview dist 1#4579
Merged
pawelszczerbuk merged 1 commit intoAug 26, 2024
Merged
Conversation
chris002oak
approved these changes
Aug 26, 2024
ThomasRaoux
approved these changes
Aug 26, 2024
Collaborator
ThomasRaoux
left a comment
ThomasRaoux
left a comment
There was a problem hiding this comment.
ouch, sorry I think it was my bug :(
bertmaher
pushed a commit
to bertmaher/triton
that referenced
this pull request
Dec 10, 2024
… 1 (triton-lang#4579) If the subview for the mma operand is in the previous iteration of the loop, it would be skipped by the code that looks for it, if it feeds directly into the loop yield. This PR fixes that issue allowing for them subview to be found and enabling the pipelining in some cases skipped previously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the subview for the mma operand is in the previous iteration of the loop, it would be skipped by the code that looks for it, if it feeds directly into the loop yield. This PR fixes that issue allowing for them subview to be found and enabling the pipelining in some cases skipped previously.